fix(isUUID): handle of null version value #1777
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
theteladras
force-pushed
the
master
branch
7 times, most recently
from
837cdb5
to
1c84bc2
Compare
fedeci
reviewed
Oct 12, 2021
theteladras
force-pushed
the
master
branch
2 times, most recently
from
033b22f
to
53999d5
Compare
tux-tn
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Thank you @theteladras for your efforts ! LGTM 🎉
We should replace this with the nullish coalescing operator when the CI/Testing problems will be fixed!
tux-tn
added
ready-to-land
profnandaa
approved these changes
Oct 30, 2021
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here lies in that, where the defaulting of argument is only managed for when the value of the version is 'undefined', and for other falsy values (in my case 'null') it accepts them. There are cases where functions do trigger callbacks with null values instead of undefined, and it usually leads to unexpected outcomes. I do believe that this is the general understanding of how the function should be used, when the version argument is falsy, it should check for 'all' pattern.
The particular issue is here:
Checklist